diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2018-11-09 12:22:30 +0800 |
|---|---|---|
| committer | Joyee Cheung <joyeec9h3@gmail.com> | 2018-11-14 02:59:45 +0800 |
| commit | 51cea618e21ba88bc20feb537a72c1b831a94b46 (patch) | |
| tree | 8a28c72d47628308c9baf51af6d75379197de420 /src/node_util.cc | |
| parent | 8c60d931f2046c1a552bed1e0d5d84f731204770 (diff) | |
| download | android-node-v8-51cea618e21ba88bc20feb537a72c1b831a94b46.tar.gz android-node-v8-51cea618e21ba88bc20feb537a72c1b831a94b46.tar.bz2 android-node-v8-51cea618e21ba88bc20feb537a72c1b831a94b46.zip | |
os: do not call into JS to push values to an array in GetCPUInfo
Instead of calling into JS from C++ to push values into an array,
use the new Array::New API that takes a pointer and a length
directly.
PR-URL: https://github.com/nodejs/node/pull/24264
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'src/node_util.cc')
| -rw-r--r-- | src/node_util.cc | 7 |
1 files changed, 0 insertions, 7 deletions
diff --git a/src/node_util.cc b/src/node_util.cc index 62af7a1115..1a08c0e255 100644 --- a/src/node_util.cc +++ b/src/node_util.cc @@ -24,7 +24,6 @@ using v8::Private; using v8::Promise; using v8::PropertyFilter; using v8::Proxy; -using v8::ReadOnly; using v8::SKIP_STRINGS; using v8::SKIP_SYMBOLS; using v8::String; @@ -206,12 +205,6 @@ void Initialize(Local<Object> target, } #undef V - target->DefineOwnProperty( - env->context(), - OneByteString(env->isolate(), "pushValToArrayMax"), - Integer::NewFromUnsigned(env->isolate(), NODE_PUSH_VAL_TO_ARRAY_MAX), - ReadOnly).FromJust(); - #define V(name) \ target->Set(context, \ FIXED_ONE_BYTE_STRING(env->isolate(), #name), \ |