summaryrefslogtreecommitdiff
path: root/node.gypi
diff options
context:
space:
mode:
authorRefael Ackermann <refack@gmail.com>2018-11-20 11:26:48 -0500
committerRich Trott <rtrott@gmail.com>2018-12-01 07:20:58 -0800
commiteb6741b15ebd93ffdd71e87cbc1350b9e94ef222 (patch)
tree8f9a34cac6b314313c6041464420075b7398aabe /node.gypi
parent0d2311820d50e29b83eb9f885d961f9b43dfd165 (diff)
downloadandroid-node-v8-eb6741b15ebd93ffdd71e87cbc1350b9e94ef222.tar.gz
android-node-v8-eb6741b15ebd93ffdd71e87cbc1350b9e94ef222.tar.bz2
android-node-v8-eb6741b15ebd93ffdd71e87cbc1350b9e94ef222.zip
build: fix c++ code coverage on macOS
PR-URL: https://github.com/nodejs/node/pull/24520 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'node.gypi')
-rw-r--r--node.gypi19
1 files changed, 11 insertions, 8 deletions
diff --git a/node.gypi b/node.gypi
index fdf81b7465..665fc627b3 100644
--- a/node.gypi
+++ b/node.gypi
@@ -274,25 +274,28 @@
'-Wl,--whole-archive <(v8_base)',
'-Wl,--no-whole-archive' ]
}],
- [ 'OS in "mac freebsd linux" and node_shared=="false"'
- ' and coverage=="true"', {
+ [ 'coverage=="true" and node_shared=="false" and OS in "mac freebsd linux"', {
+ 'cflags!': [ '-O3' ],
'ldflags': [ '--coverage',
'-g',
'-O0' ],
'cflags': [ '--coverage',
'-g',
'-O0' ],
- 'cflags!': [ '-O3' ],
'xcode_settings': {
- 'OTHER_LDFLAGS': [
- '--coverage',
- ],
- 'OTHER_CFLAGS+': [
+ 'OTHER_CFLAGS': [
'--coverage',
'-g',
'-O0'
],
- }
+ },
+ 'conditions': [
+ [ '_type=="executable"', {
+ 'xcode_settings': {
+ 'OTHER_LDFLAGS': [ '--coverage', ],
+ },
+ }],
+ ],
}],
[ 'OS=="sunos"', {
'ldflags': [ '-Wl,-M,/usr/lib/ld/map.noexstk' ],