diff options
author | Yihong Wang <yh.wang@ibm.com> | 2017-11-01 21:19:16 -0700 |
---|---|---|
committer | Refael Ackermann <refack@gmail.com> | 2017-11-10 16:47:40 -0500 |
commit | b340c2d4dd9d774dbed35ca1c33678ff30d46192 (patch) | |
tree | daae1012bec8c23d9dca92007fae657aa51ab23e /node.gypi | |
parent | 3cacd34dc2c5da4c01c8fd09c34a816357358c8b (diff) | |
download | android-node-v8-b340c2d4dd9d774dbed35ca1c33678ff30d46192.tar.gz android-node-v8-b340c2d4dd9d774dbed35ca1c33678ff30d46192.tar.bz2 android-node-v8-b340c2d4dd9d774dbed35ca1c33678ff30d46192.zip |
build: remove cctest extension
cctest has `so.59` extension when building node shared library in linux.
The appending is defined in node.gypi and the cctest target in node.gyp
includes node.gypi. Moving the appending from node.gypi to node target
in node.gyp fixes the issue.
Signed-off-by: Yihong Wang <yh.wang@ibm.com>
PR-URL: https://github.com/nodejs/node/pull/16680
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'node.gypi')
-rw-r--r-- | node.gypi | 5 |
1 files changed, 0 insertions, 5 deletions
@@ -11,11 +11,6 @@ 'defines': [ 'NODE_SHARED_MODE', ], - 'conditions': [ - [ 'node_module_version!="" and OS!="win"', { - 'product_extension': '<(shlib_suffix)', - }] - ], }], [ 'node_enable_d8=="true"', { 'dependencies': [ 'deps/v8/src/d8.gyp:d8' ], |