diff options
| author | Yang Guo <yangguo@chromium.org> | 2018-01-11 13:25:09 +0100 |
|---|---|---|
| committer | Myles Borins <mylesborins@google.com> | 2018-04-11 13:23:22 -0400 |
| commit | 5c93b3b561ace4c3dcf6b74111e8d8be4be0baca (patch) | |
| tree | 81cbd70ac90bc85a7732129344405068be470c96 /node.gypi | |
| parent | dd49677096c76dfc731937d73688c4b10e38ae23 (diff) | |
| download | android-node-v8-5c93b3b561ace4c3dcf6b74111e8d8be4be0baca.tar.gz android-node-v8-5c93b3b561ace4c3dcf6b74111e8d8be4be0baca.tar.bz2 android-node-v8-5c93b3b561ace4c3dcf6b74111e8d8be4be0baca.zip | |
build: add option to build v8 with GN
PR-URL: https://github.com/nodejs/node/pull/19201
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'node.gypi')
| -rw-r--r-- | node.gypi | 17 |
1 files changed, 13 insertions, 4 deletions
@@ -59,9 +59,15 @@ 'dependencies': [ 'deps/v8/gypfiles/d8.gyp:d8' ], }], [ 'node_use_bundled_v8=="true"', { - 'dependencies': [ - 'deps/v8/gypfiles/v8.gyp:v8', - 'deps/v8/gypfiles/v8.gyp:v8_libplatform' + 'conditions': [ + [ 'build_v8_with_gn=="true"', { + 'dependencies': ['deps/v8/gypfiles/v8.gyp:v8_monolith'], + }, { + 'dependencies': [ + 'deps/v8/gypfiles/v8.gyp:v8', + 'deps/v8/gypfiles/v8.gyp:v8_libplatform', + ], + }], ], }], [ 'node_use_v8_platform=="true"', { @@ -111,7 +117,6 @@ 'defines': [ 'NODE_NO_BROWSER_GLOBALS' ], } ], [ 'node_use_bundled_v8=="true" and v8_postmortem_support=="true"', { - 'dependencies': [ 'deps/v8/gypfiles/v8.gyp:postmortem-metadata' ], 'conditions': [ # -force_load is not applicable for the static library [ 'force_load=="true"', { @@ -121,6 +126,10 @@ ], }, }], + # when building with GN, the v8_monolith target already includes postmortem metadata + [ 'build_v8_with_gn=="false"', { + 'dependencies': [ 'deps/v8/gypfiles/v8.gyp:postmortem-metadata' ], + }], ], }], [ 'node_shared_zlib=="false"', { |