summaryrefslogtreecommitdiff
path: root/lib
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2019-02-09 17:30:33 +0100
committerAnna Henningsen <anna@addaleax.net>2019-02-12 01:17:13 +0100
commit9e84a26cb3d390a6ce051b75c892094fff233f92 (patch)
tree8a5a7e0d7dd224cc2c227bc71509d91563d4687f /lib
parent2c84f6e75cc513fe6e958f0489d104ee883db232 (diff)
downloadandroid-node-v8-9e84a26cb3d390a6ce051b75c892094fff233f92.tar.gz
android-node-v8-9e84a26cb3d390a6ce051b75c892094fff233f92.tar.bz2
android-node-v8-9e84a26cb3d390a6ce051b75c892094fff233f92.zip
worker: keep stdio after exit
This addresses review comments from https://github.com/nodejs/node/pull/25871. Refs: https://github.com/nodejs/node/pull/25871 PR-URL: https://github.com/nodejs/node/pull/26017 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'lib')
-rw-r--r--lib/internal/worker.js7
1 files changed, 0 insertions, 7 deletions
diff --git a/lib/internal/worker.js b/lib/internal/worker.js
index 6d833bcbd2..f43a961049 100644
--- a/lib/internal/worker.js
+++ b/lib/internal/worker.js
@@ -171,7 +171,6 @@ class Worker extends EventEmitter {
this[kPublicPort] = null;
const { stdout, stderr } = this[kParentSideStdio];
- this[kParentSideStdio] = null;
if (!stdout._readableState.ended) {
debug(`[${threadId}] explicitly closes stdout for ${this.threadId}`);
@@ -221,20 +220,14 @@ class Worker extends EventEmitter {
}
get stdin() {
- if (this[kParentSideStdio] === null) return null;
-
return this[kParentSideStdio].stdin;
}
get stdout() {
- if (this[kParentSideStdio] === null) return null;
-
return this[kParentSideStdio].stdout;
}
get stderr() {
- if (this[kParentSideStdio] === null) return null;
-
return this[kParentSideStdio].stderr;
}
}