diff options
| author | Trivikram Kamat <16024985+trivikr@users.noreply.github.com> | 2018-04-03 11:04:30 -0700 |
|---|---|---|
| committer | Trivikram Kamat <16024985+trivikr@users.noreply.github.com> | 2018-04-05 18:39:17 -0700 |
| commit | f02e4b90a2c1cdcb0b0d20bcfa75bac8d991d66b (patch) | |
| tree | da29736c4563bf79ab1d7ef22b46e412bcba170d /doc/guides/contributing | |
| parent | 682b85036efcaa87c580483f68ba71fbb13af4b9 (diff) | |
| download | android-node-v8-f02e4b90a2c1cdcb0b0d20bcfa75bac8d991d66b.tar.gz android-node-v8-f02e4b90a2c1cdcb0b0d20bcfa75bac8d991d66b.tar.bz2 android-node-v8-f02e4b90a2c1cdcb0b0d20bcfa75bac8d991d66b.zip | |
doc: create list for commonly edited files in PRs
PR-URL: https://github.com/nodejs/node/pull/19776
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'doc/guides/contributing')
| -rw-r--r-- | doc/guides/contributing/pull-requests.md | 8 |
1 files changed, 5 insertions, 3 deletions
diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index 7aaf30c62b..0bb4c4c003 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -101,9 +101,11 @@ $ git checkout -b my-branch -t upstream/master ### Step 3: Code The vast majority of Pull Requests opened against the `nodejs/node` -repository includes changes to either the C/C++ code contained in the `src` -directory, the JavaScript code contained in the `lib` directory, the -documentation in `docs/api` or tests within the `test` directory. +repository includes changes to one or more of the following: + - the C/C++ code contained in the `src` directory + - the JavaScript code contained in the `lib` directory + - the documentation in `doc/api` + - tests within the `test` directory. If you are modifying code, please be sure to run `make lint` from time to time to ensure that the changes follow the Node.js code style guide. |