diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-05-02 09:03:47 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-05-03 13:44:42 -0700 |
| commit | b3c757e07a6883e77279747fb522b215460fdbbf (patch) | |
| tree | 1b2420e909fbd12179bba0d23c7c9b6a80ba2e7b /doc/guides/contributing | |
| parent | a59826403a76fcc7a6685a52ee82d19be323a699 (diff) | |
| download | android-node-v8-b3c757e07a6883e77279747fb522b215460fdbbf.tar.gz android-node-v8-b3c757e07a6883e77279747fb522b215460fdbbf.tar.bz2 android-node-v8-b3c757e07a6883e77279747fb522b215460fdbbf.zip | |
doc: update Collaborator Guide reference
In pull-requests.md:
* Refer to the Collaborator Guide as Collaborator Guide and not
Collaborator's Guide. That is how the doc describes itself and we
should be consistent.
PR-URL: https://github.com/nodejs/node/pull/20473
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'doc/guides/contributing')
| -rw-r--r-- | doc/guides/contributing/pull-requests.md | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index a92e1cf305..0da7022d10 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -35,7 +35,7 @@ so that you can make the actual changes. This is where we will start. * [Getting Approvals for your Pull Request](#getting-approvals-for-your-pull-request) * [CI Testing](#ci-testing) * [Waiting Until the Pull Request Gets Landed](#waiting-until-the-pull-request-gets-landed) - * [Check Out the Collaborator's Guide](#check-out-the-collaborators-guide) + * [Check Out the Collaborator Guide](#check-out-the-collaborator-guide) ## Dependencies @@ -645,17 +645,17 @@ doesn't need to wait. A Pull Request may well take longer to be merged in. All these precautions are important because Node.js is widely used, so don't be discouraged! -### Check Out the Collaborator's Guide +### Check Out the Collaborator Guide -If you want to know more about the code review and the landing process, -you can take a look at the -[collaborator's guide](https://github.com/nodejs/node/blob/master/COLLABORATOR_GUIDE.md). +If you want to know more about the code review and the landing process, see the +[Collaborator Guide][]. [approved]: #getting-approvals-for-your-pull-request [benchmark results]: ../writing-and-running-benchmarks.md [Building guide]: ../../../BUILDING.md [CI (Continuous Integration) test run]: #ci-testing [Code of Conduct]: https://github.com/nodejs/admin/blob/master/CODE_OF_CONDUCT.md +[Collaborator Guide]: ../../../COLLABORATOR_GUIDE.md [guide for writing tests in Node.js]: ../writing-tests.md [https://ci.nodejs.org/]: https://ci.nodejs.org/ [IRC in the #node-dev channel]: https://webchat.freenode.net?channels=node-dev&uio=d4 |