diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-10-06 21:35:01 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-10-07 16:44:43 -0700 |
| commit | b155358235df5b4158607787dc18d82e05ceea02 (patch) | |
| tree | ca0f0bf7fd10aab6fabd1dd2edc071629e69f5eb /doc/guides/contributing | |
| parent | a9bb653ecc9cab6317f931fe39d4cfe5642ab37b (diff) | |
| download | android-node-v8-b155358235df5b4158607787dc18d82e05ceea02.tar.gz android-node-v8-b155358235df5b4158607787dc18d82e05ceea02.tar.bz2 android-node-v8-b155358235df5b4158607787dc18d82e05ceea02.zip | |
doc: remove 72-hour mentions in pull-requests.md
vsemozhetbyt noted that there were two mentions of the now-defunct
72-hour-rule in pull-requests.md. This change updates the text to
reflect current wait-time rules.
PR-URL: https://github.com/nodejs/node/pull/23309
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'doc/guides/contributing')
| -rw-r--r-- | doc/guides/contributing/pull-requests.md | 22 |
1 files changed, 10 insertions, 12 deletions
diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index 783d77c8c5..b83624ac5f 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -496,12 +496,11 @@ There is a minimum waiting time which we try to respect for non-trivial changes, so that people who may have important input in such a distributed project are able to respond. -For non-trivial changes, Pull Requests must be left open for *at least* 48 -hours during the week, and 72 hours on a weekend. In most cases, when the -PR is relatively small and focused on a narrow set of changes, these periods -provide more than enough time to adequately review. Sometimes changes take far -longer to review, or need more specialized review from subject matter experts. -When in doubt, do not rush. +For non-trivial changes, Pull Requests must be left open for at least 48 hours. +In most cases, when the PR is relatively small and focused on a narrow set of +changes, that will provide more than enough time to adequately review. Sometimes +changes take far longer to review, or need more specialized review from subject +matter experts. When in doubt, do not rush. Trivial changes, typically limited to small formatting changes or fixes to documentation, may be landed within the minimum 48 hour window. @@ -643,12 +642,11 @@ If not, you can ask a Collaborator to start a CI run. ### Waiting Until the Pull Request Gets Landed -A Pull Request needs to stay open for at least 48 hours (72 hours on a -weekend) from when it is submitted, even after it gets approved and -passes the CI. This is to make sure that everyone has a chance to -weigh in. If the changes are trivial, collaborators may decide it -doesn't need to wait. A Pull Request may well take longer to be -merged in. All these precautions are important because Node.js is +A Pull Request needs to stay open for at least 48 hours from when it is +submitted, even after it gets approved and passes the CI. This is to make sure +that everyone has a chance to weigh in. If the changes are trivial, +collaborators may decide it doesn't need to wait. A Pull Request may well take +longer to be merged in. All these precautions are important because Node.js is widely used, so don't be discouraged! ### Check Out the Collaborator Guide |