diff options
| author | Vse Mozhet Byt <vsemozhetbyt@gmail.com> | 2018-11-22 00:38:05 +0200 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-11-21 20:01:27 -0800 |
| commit | 9c7b87b9a16837c9bd3d7b6514cdee6f0933bfbc (patch) | |
| tree | 40b95c0db5736671b848b67fa91ad68c5c02653f /doc/guides/contributing | |
| parent | d1a55d329a0039061915f904baafb1abfced22ab (diff) | |
| download | android-node-v8-9c7b87b9a16837c9bd3d7b6514cdee6f0933bfbc.tar.gz android-node-v8-9c7b87b9a16837c9bd3d7b6514cdee6f0933bfbc.tar.bz2 android-node-v8-9c7b87b9a16837c9bd3d7b6514cdee6f0933bfbc.zip | |
doc,meta: update PR approving info
Refs: https://github.com/nodejs/node/pull/22255
PR-URL: https://github.com/nodejs/node/pull/24561
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Diffstat (limited to 'doc/guides/contributing')
| -rw-r--r-- | doc/guides/contributing/pull-requests.md | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index ea28001b69..959d388de1 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -347,7 +347,8 @@ unhelpful is likely safe to ignore. ### Step 10: Landing In order to land, a Pull Request needs to be reviewed and [approved][] by -at least one Node.js Collaborator and pass a +at least two Node.js Collaborators (one Collaborator approval is enough if the +pull request has been open for more than 7 days) and pass a [CI (Continuous Integration) test run][]. After that, as long as there are no objections from other contributors, the Pull Request can be merged. If you find your Pull Request waiting longer than you expect, see the |