summaryrefslogtreecommitdiff
path: root/doc/guides/contributing
diff options
context:
space:
mode:
authorVse Mozhet Byt <vsemozhetbyt@gmail.com>2018-04-19 15:02:31 +0300
committerVse Mozhet Byt <vsemozhetbyt@gmail.com>2018-04-19 22:10:24 +0300
commit810597d3353c85eb0aebdf16509a75e4f7dfb6e1 (patch)
treeb2d9896a6328915283ed102b6ca7775dcd9f9481 /doc/guides/contributing
parent3d480dcf4c270cbf5a3acef08fc6b8d25576411b (diff)
downloadandroid-node-v8-810597d3353c85eb0aebdf16509a75e4f7dfb6e1.tar.gz
android-node-v8-810597d3353c85eb0aebdf16509a75e4f7dfb6e1.tar.bz2
android-node-v8-810597d3353c85eb0aebdf16509a75e4f7dfb6e1.zip
doc: add hiding comments note to contributor guide
PR-URL: https://github.com/nodejs/node/pull/20149 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Diffstat (limited to 'doc/guides/contributing')
-rw-r--r--doc/guides/contributing/pull-requests.md5
1 files changed, 5 insertions, 0 deletions
diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md
index 4d22004664..b6cc9eeeef 100644
--- a/doc/guides/contributing/pull-requests.md
+++ b/doc/guides/contributing/pull-requests.md
@@ -475,6 +475,10 @@ opportunity for the contributor to learn a bit more about the project.
It is always good to clearly indicate nits when you comment: e.g.
`Nit: change foo() to bar(). But this is not blocking.`
+If your comments were addressed but were not folded automatically after new
+commits or if they proved to be mistaken, please, [hide them][hiding-a-comment]
+with the appropriate reason to keep the conversation flow concise and relevant.
+
### Be aware of the person behind the code
Be aware that *how* you communicate requests and reviews in your feedback can
@@ -658,3 +662,4 @@ you can take a look at the
[https://ci.nodejs.org/]: https://ci.nodejs.org/
[IRC in the #node-dev channel]: https://webchat.freenode.net?channels=node-dev&uio=d4
[Onboarding guide]: ../../onboarding.md
+[hiding-a-comment]: https://help.github.com/articles/managing-disruptive-comments/#hiding-a-comment