diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-10-31 21:57:58 -0700 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-11-05 05:59:49 +0100 |
| commit | 7e1b178fb637abc68b1d4da1363a19db7ad02d6c (patch) | |
| tree | 888d9445c37898a94b6527964a1c1bed9222026a /doc/guides/contributing | |
| parent | b62349137106a0bb8a418947b76216868886e87c (diff) | |
| download | android-node-v8-7e1b178fb637abc68b1d4da1363a19db7ad02d6c.tar.gz android-node-v8-7e1b178fb637abc68b1d4da1363a19db7ad02d6c.tar.bz2 android-node-v8-7e1b178fb637abc68b1d4da1363a19db7ad02d6c.zip | |
doc: streamline CONTRIBUTING.md
PR-URL: https://github.com/nodejs/node/pull/24010
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Diffstat (limited to 'doc/guides/contributing')
| -rw-r--r-- | doc/guides/contributing/pull-requests.md | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index 15c31cec71..2c0d8d6ccb 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -29,7 +29,7 @@ so that you can make the actual changes. This is where we will start. * [Accept that there are different opinions about what belongs in Node.js](#accept-that-there-are-different-opinions-about-what-belongs-in-nodejs) * [Performance is not everything](#performance-is-not-everything) * [Continuous Integration Testing](#continuous-integration-testing) -* [Additional Notes](#additional-notes) +* [Notes](#notes) * [Commit Squashing](#commit-squashing) * [Getting Approvals for your Pull Request](#getting-approvals-for-your-pull-request) * [CI Testing](#ci-testing) @@ -531,7 +531,7 @@ specific platforms or for so-called "flaky" tests to fail ("be red"). It is vital to visually inspect the results of all failed ("red") tests to determine whether the failure was caused by the changes in the Pull Request. -## Additional Notes +## Notes ### Commit Squashing |