diff options
| author | Vse Mozhet Byt <vsemozhetbyt@gmail.com> | 2018-04-22 03:35:12 +0300 |
|---|---|---|
| committer | Vse Mozhet Byt <vsemozhetbyt@gmail.com> | 2018-04-22 13:25:07 +0300 |
| commit | 2060787d386099ceadbb6de2d81dc2f34c90503d (patch) | |
| tree | 8489132310c22d2f4946885b8afc46128db8e57a /doc/guides/contributing | |
| parent | 3eeb346aa96790765234f8e4759dd5896754067f (diff) | |
| download | android-node-v8-2060787d386099ceadbb6de2d81dc2f34c90503d.tar.gz android-node-v8-2060787d386099ceadbb6de2d81dc2f34c90503d.tar.bz2 android-node-v8-2060787d386099ceadbb6de2d81dc2f34c90503d.zip | |
meta: document commit msg exception for long URLs
PR-URL: https://github.com/nodejs/node/pull/20207
Fixes: https://github.com/nodejs/node/issues/17116
Refs: https://github.com/nodejs/core-validate-commit/issues/24
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'doc/guides/contributing')
| -rw-r--r-- | doc/guides/contributing/pull-requests.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index b6cc9eeeef..f481a2cacb 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -151,7 +151,7 @@ A good commit message should describe what changed and why. 2. Keep the second line blank. -3. Wrap all other lines at 72 columns. +3. Wrap all other lines at 72 columns (except for long URLs). 4. If your patch fixes an open issue, you can add a reference to it at the end of the log. Use the `Fixes:` prefix and the full issue URL. For other references |