summaryrefslogtreecommitdiff
path: root/doc/guides/contributing/pull-requests.md
diff options
context:
space:
mode:
authorRich Trott <rtrott@gmail.com>2019-11-12 19:50:09 -0800
committerRich Trott <rtrott@gmail.com>2019-11-14 22:09:27 -0800
commit794d8be94e65a13cdbe12ea296637fe9e57e2878 (patch)
treed6e222783e0ee35548f542491b0705b5bc05a252 /doc/guides/contributing/pull-requests.md
parentc71b89eb0607a875ed93b2d946e0dc650fab730b (diff)
downloadandroid-node-v8-794d8be94e65a13cdbe12ea296637fe9e57e2878.tar.gz
android-node-v8-794d8be94e65a13cdbe12ea296637fe9e57e2878.tar.bz2
android-node-v8-794d8be94e65a13cdbe12ea296637fe9e57e2878.zip
doc: simplify text in pull-requests.md
Mostly, this replaces "It is recommended to do X" with "Do X." PR-URL: https://github.com/nodejs/node/pull/30458 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'doc/guides/contributing/pull-requests.md')
-rw-r--r--doc/guides/contributing/pull-requests.md4
1 files changed, 2 insertions, 2 deletions
diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md
index 17257674a3..f23c92fa02 100644
--- a/doc/guides/contributing/pull-requests.md
+++ b/doc/guides/contributing/pull-requests.md
@@ -73,7 +73,7 @@ $ git remote add upstream https://github.com/nodejs/node.git
$ git fetch upstream
```
-It is recommended to configure `git` so that it knows who you are:
+Configure `git` so that it knows who you are:
```text
$ git config user.name "J. Random User"
@@ -125,7 +125,7 @@ For contributing C++ code, you may want to look at the
### Step 4: Commit
-It is a recommended best practice to keep your changes as logically grouped
+It is a best practice to keep your changes as logically grouped
as possible within individual commits. There is no limit to the number of
commits any single Pull Request may have, and many contributors find it easier
to review changes that are split across multiple commits.