summaryrefslogtreecommitdiff
path: root/doc/guides/contributing/pull-requests.md
diff options
context:
space:
mode:
authorGlen Keane <glenkeane.94@gmail.com>2018-02-24 22:38:04 +0000
committerGlen Keane <glenkeane.94@gmail.com>2018-03-01 16:44:43 +0000
commit30fd3d25dfa0cb759da77e9725e6cec4af1415b9 (patch)
treeb33fbb597af2dfc3081acadd10942d2c2d7f3d94 /doc/guides/contributing/pull-requests.md
parent38eb0fa7372052433520ea2e1575072892bc5eec (diff)
downloadandroid-node-v8-30fd3d25dfa0cb759da77e9725e6cec4af1415b9.tar.gz
android-node-v8-30fd3d25dfa0cb759da77e9725e6cec4af1415b9.tar.bz2
android-node-v8-30fd3d25dfa0cb759da77e9725e6cec4af1415b9.zip
src: Remove lttng support.
This cleans up and removes lttng support completely. Recent discussion on a PR to deprecate lttng suggested that we remove it completely pending feedback from the TSC. This should be considered a non breaking change, as a recent PR reveals that compiling with this system has been broken for nearly two years. Refs: https://github.com/nodejs/node/issues/18971 Refs: https://github.com/nodejs/node/pull/18975 Refs: https://github.com/nodejs/node/pull/18945 PR-URL: https://github.com/nodejs/node/pull/18982 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jackson Tian <shyvo1987@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'doc/guides/contributing/pull-requests.md')
-rw-r--r--doc/guides/contributing/pull-requests.md2
1 files changed, 1 insertions, 1 deletions
diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md
index 4fd2de923a..b80fe687ef 100644
--- a/doc/guides/contributing/pull-requests.md
+++ b/doc/guides/contributing/pull-requests.md
@@ -146,7 +146,7 @@ A good commit message should describe what changed and why.
Examples:
- `net: add localAddress and localPort to Socket`
- - `src: fix typos in node_lttng_provider.h`
+ - `src: fix typos in async_wrap.h`
2. Keep the second line blank.