diff options
| author | Joao Reis <reis@janeasystems.com> | 2019-11-01 08:39:18 +0100 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2019-11-08 15:50:49 +0100 |
| commit | d776cebbfb1e4e4e878076d0c5af4f099a9f9354 (patch) | |
| tree | 8a6ea5a0716627d2a0e62c6fe2661d64e5cfdb02 /deps | |
| parent | d0f2b1701e69997f062d0cb2de6cc7b43210c68f (diff) | |
| download | android-node-v8-d776cebbfb1e4e4e878076d0c5af4f099a9f9354.tar.gz android-node-v8-d776cebbfb1e4e4e878076d0c5af4f099a9f9354.tar.bz2 android-node-v8-d776cebbfb1e4e4e878076d0c5af4f099a9f9354.zip | |
deps: make v8.h compatible with VS2015
There is a bug in the most recent version of VS2015 that affects v8.h
and therefore prevents compilation of addons.
Refs: https://stackoverflow.com/q/38378693
PR-URL: https://github.com/nodejs/node/pull/30020
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Diffstat (limited to 'deps')
| -rw-r--r-- | deps/v8/include/v8.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/deps/v8/include/v8.h b/deps/v8/include/v8.h index 615911ef46..12fc16c2be 100644 --- a/deps/v8/include/v8.h +++ b/deps/v8/include/v8.h @@ -1738,9 +1738,11 @@ class V8_EXPORT ScriptCompiler { public: enum Encoding { ONE_BYTE, TWO_BYTE, UTF8 }; +#if defined(_MSC_VER) && _MSC_VER >= 1910 /* Disable on VS2015 */ V8_DEPRECATE_SOON( "This class takes ownership of source_stream, so use the constructor " "taking a unique_ptr to make these semantics clearer") +#endif StreamedSource(ExternalSourceStream* source_stream, Encoding encoding); StreamedSource(std::unique_ptr<ExternalSourceStream> source_stream, Encoding encoding); |