diff options
| author | Michaël Zasso <targos@protonmail.com> | 2019-10-09 11:16:40 +0200 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2019-10-11 11:41:35 +0200 |
| commit | a350d8b7805765744a10415551bd4a741b6519ff (patch) | |
| tree | c826d018d625a73afae5ee8a5fe3fb3bd9b8b28c /deps | |
| parent | 6b962ddf01f404a51deed683b3a88ea19276107c (diff) | |
| download | android-node-v8-a350d8b7805765744a10415551bd4a741b6519ff.tar.gz android-node-v8-a350d8b7805765744a10415551bd4a741b6519ff.tar.bz2 android-node-v8-a350d8b7805765744a10415551bd4a741b6519ff.zip | |
deps: V8: cherry-pick 53e62af
Original commit message:
[build] Include string in v8.h
Explicitly #include<string> in v8.h, since std::string is referenced
in it. In the C++ STL shipped with Visual Studio 2019, none of the
headers included in v8.h ends up including the C++ string header, which
caused a compile error.
Bug: v8:9793
Change-Id: I84a133dd10dd6dcc7b70287af393e82cf0dc97df
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1834321
Reviewed-by: Adam Klein <adamk@chromium.org>
Commit-Queue: Adam Klein <adamk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#64074}
Refs: https://github.com/v8/v8/commit/53e62affd33ad036a169eff7d6c1d50b0adcd21a
PR-URL: https://github.com/nodejs/node/pull/29898
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gus Caplan <me@gus.host>
Diffstat (limited to 'deps')
| -rw-r--r-- | deps/v8/include/v8.h | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/deps/v8/include/v8.h b/deps/v8/include/v8.h index 735701d232..fa26d2dd36 100644 --- a/deps/v8/include/v8.h +++ b/deps/v8/include/v8.h @@ -19,6 +19,7 @@ #include <stdint.h> #include <stdio.h> #include <memory> +#include <string> #include <type_traits> #include <utility> #include <vector> |