summaryrefslogtreecommitdiff
path: root/deps
diff options
context:
space:
mode:
authorSam Roberts <vieuxtech@gmail.com>2018-12-21 15:49:29 -0800
committerSam Roberts <vieuxtech@gmail.com>2018-12-27 14:35:43 -0800
commit59fa7f12571f721bfe2f5952bc7fe415abb3ad1c (patch)
treecd6b7bb0f9dc652cd227da9a043f43ef793fcd44 /deps
parenteaa1544d974d701c1eed7b42308ca6031e65c833 (diff)
downloadandroid-node-v8-59fa7f12571f721bfe2f5952bc7fe415abb3ad1c.tar.gz
android-node-v8-59fa7f12571f721bfe2f5952bc7fe415abb3ad1c.tar.bz2
android-node-v8-59fa7f12571f721bfe2f5952bc7fe415abb3ad1c.zip
deps: cherry-pick 26b145a from upstream V8
Original commit message: [api] Deprecate ExternalStringResourceBase::IsCompressible R=yangguo@chromium.org Bug: v8:8238 Change-Id: Ia59aefc54c2e9f4fa3348c42fb45e7fadab8ee76 Reviewed-on: https://chromium-review.googlesource.com/c/1349231 Reviewed-by: Yang Guo <yangguo@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#57788} Refs: https://github.com/v8/v8/commit/26b145ab12993b1585396a3f346b3c3aca093204 PR-URL: https://github.com/nodejs/node/pull/25148 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Michaƫl Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'deps')
-rw-r--r--deps/v8/include/v8.h14
1 files changed, 2 insertions, 12 deletions
diff --git a/deps/v8/include/v8.h b/deps/v8/include/v8.h
index 9b7be9fb93..01fb56b55d 100644
--- a/deps/v8/include/v8.h
+++ b/deps/v8/include/v8.h
@@ -2631,8 +2631,7 @@ class V8_EXPORT String : public Name {
public:
virtual ~ExternalStringResourceBase() = default;
- V8_DEPRECATE_SOON("Use IsCacheable().",
- virtual bool IsCompressible() const) {
+ V8_DEPRECATED("Use IsCacheable().", virtual bool IsCompressible() const) {
return false;
}
@@ -2641,16 +2640,7 @@ class V8_EXPORT String : public Name {
* ExternalStringResource::data() may be cached, otherwise it is not
* expected to be stable beyond the current top-level task.
*/
- virtual bool IsCacheable() const {
-#if __clang__
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
-#endif
- return !IsCompressible();
-#if __clang__
-#pragma clang diagnostic pop
-#endif
- }
+ virtual bool IsCacheable() const { return true; }
protected:
ExternalStringResourceBase() = default;