diff options
| author | Ujjwal Sharma <usharma1998@gmail.com> | 2019-09-14 09:20:31 +0530 |
|---|---|---|
| committer | Michaël Zasso <targos@protonmail.com> | 2019-11-08 15:46:47 +0100 |
| commit | 54af1e709c32af66602e06f32e3b10a52a813c99 (patch) | |
| tree | 4a5b543af8ffbce2da6e1548b1bf34a1027806d9 /deps | |
| parent | 5c25db3510c97e6a813481a29eadfb66152328f5 (diff) | |
| download | android-node-v8-54af1e709c32af66602e06f32e3b10a52a813c99.tar.gz android-node-v8-54af1e709c32af66602e06f32e3b10a52a813c99.tar.bz2 android-node-v8-54af1e709c32af66602e06f32e3b10a52a813c99.zip | |
deps: patch V8 to run on older XCode versions
Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional
property, which is a fairly new C++ feature, since that requires a newer
XCode version than the minimum requirement in BUILDING.md and thus
breaks CI.
PR-URL: https://github.com/nodejs/node/pull/29694
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Diffstat (limited to 'deps')
| -rw-r--r-- | deps/v8/src/compiler/js-heap-broker.cc | 1 | ||||
| -rw-r--r-- | deps/v8/src/interpreter/interpreter.cc | 2 |
2 files changed, 2 insertions, 1 deletions
diff --git a/deps/v8/src/compiler/js-heap-broker.cc b/deps/v8/src/compiler/js-heap-broker.cc index 9a725eb4e9..529fb8e9c1 100644 --- a/deps/v8/src/compiler/js-heap-broker.cc +++ b/deps/v8/src/compiler/js-heap-broker.cc @@ -4203,6 +4203,7 @@ GlobalAccessFeedback::GlobalAccessFeedback(PropertyCellRef cell, GlobalAccessFeedback::GlobalAccessFeedback(FeedbackSlotKind slot_kind) : ProcessedFeedback(kGlobalAccess, slot_kind), + cell_or_context_(base::nullopt), index_and_immutable_(0 /* doesn't matter */) { DCHECK(IsGlobalICKind(slot_kind)); } diff --git a/deps/v8/src/interpreter/interpreter.cc b/deps/v8/src/interpreter/interpreter.cc index 6c730d5a59..52ce4a1408 100644 --- a/deps/v8/src/interpreter/interpreter.cc +++ b/deps/v8/src/interpreter/interpreter.cc @@ -280,7 +280,7 @@ Interpreter::NewSourcePositionCollectionJob( auto job = std::make_unique<InterpreterCompilationJob>(parse_info, literal, allocator, nullptr); job->compilation_info()->SetBytecodeArray(existing_bytecode); - return job; + return std::unique_ptr<UnoptimizedCompilationJob> { static_cast<UnoptimizedCompilationJob*>(job.release()) }; } void Interpreter::ForEachBytecode( |