diff options
| author | Rod Vagg <rod@vagg.org> | 2018-11-14 14:13:57 +1100 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-11-17 06:03:50 +0100 |
| commit | 323a365766e30895860ce0e0ac95f7f33a060021 (patch) | |
| tree | 11652799b214672437fe0f5c8d5b1adfc1aa020e /deps | |
| parent | ed1c40e977cc5bb87645bc1dcf62d2e25386a2c0 (diff) | |
| download | android-node-v8-323a365766e30895860ce0e0ac95f7f33a060021.tar.gz android-node-v8-323a365766e30895860ce0e0ac95f7f33a060021.tar.bz2 android-node-v8-323a365766e30895860ce0e0ac95f7f33a060021.zip | |
deps: float 26d7fce1 from openssl
The fix for CVE-2018-0734, floated in 213c7d2d, failed to include a
constant-time calculation for one of the variables. This introduces
a fix for that.
Upstream: https://github.com/openssl/openssl/commit/26d7fce1
Original commit message:
Add a constant time flag to one of the bignums to avoid a timing leak.
Reviewed-by: Tim Hudson <tjh@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/7549)
(cherry picked from commit 00496b6423605391864fbbd1693f23631a1c5239)
PR-URL: https://github.com/nodejs/node/pull/24353
Refs: https://github.com/openssl/openssl/pull/7549
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Diffstat (limited to 'deps')
| -rw-r--r-- | deps/openssl/openssl/crypto/dsa/dsa_ossl.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/deps/openssl/openssl/crypto/dsa/dsa_ossl.c b/deps/openssl/openssl/crypto/dsa/dsa_ossl.c index be58625db3..868283ac63 100644 --- a/deps/openssl/openssl/crypto/dsa/dsa_ossl.c +++ b/deps/openssl/openssl/crypto/dsa/dsa_ossl.c @@ -225,6 +225,7 @@ static int dsa_sign_setup(DSA *dsa, BN_CTX *ctx_in, } while (BN_is_zero(k)); BN_set_flags(k, BN_FLG_CONSTTIME); + BN_set_flags(l, BN_FLG_CONSTTIME); if (dsa->flags & DSA_FLAG_CACHE_MONT_P) { if (!BN_MONT_CTX_set_locked(&dsa->method_mont_p, |