summaryrefslogtreecommitdiff
path: root/common.gypi
diff options
context:
space:
mode:
authorPeter Marshall <petermarshall@chromium.org>2018-11-09 13:06:07 +0100
committerMichaƫl Zasso <targos@protonmail.com>2018-12-06 15:25:45 +0100
commite36e9dde38caf3517890da2265e6dd9f127abe72 (patch)
treeabbc9148d312c733e32761f29b5ee1cd6ad491ca /common.gypi
parent0e090768de1844c493013d5e99bd903928aff2ab (diff)
downloadandroid-node-v8-e36e9dde38caf3517890da2265e6dd9f127abe72.tar.gz
android-node-v8-e36e9dde38caf3517890da2265e6dd9f127abe72.tar.bz2
android-node-v8-e36e9dde38caf3517890da2265e6dd9f127abe72.zip
deps: cherry-pick b87d408 from upstream V8
Original commit message: [heap-profiler] Fix a use-after-free when snapshots are deleted If a caller starts the sampling heap profiler and takes a snapshot, and then deletes the snapshot before the sampling has completed, a use-after-free will occur on the StringsStorage pointer. The same issue applies for StartTrackingHeapObjects which shares the same StringsStorage object. Bug: v8:8373 Change-Id: I5d69d60d3f9465f9dd3b3bef107c204e0fda0643 Reviewed-on: https://chromium-review.googlesource.com/c/1301477 Commit-Queue: Peter Marshall <petermarshall@chromium.org> Reviewed-by: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#57114} PR-URL: https://github.com/nodejs/node/pull/24272 Refs: https://github.com/v8/v8/commit/b87d408f65b9ab49a4d199e850d2358995deaeb2 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Diffstat (limited to 'common.gypi')
-rw-r--r--common.gypi2
1 files changed, 1 insertions, 1 deletions
diff --git a/common.gypi b/common.gypi
index fd9fe33063..cd57005308 100644
--- a/common.gypi
+++ b/common.gypi
@@ -38,7 +38,7 @@
# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
- 'v8_embedder_string': '-node.2',
+ 'v8_embedder_string': '-node.3',
##### V8 defaults for Node.js #####