diff options
| author | Refael Ackermann <refack@gmail.com> | 2018-09-30 13:44:55 -0400 |
|---|---|---|
| committer | Refael Ackermann <refack@gmail.com> | 2018-10-02 17:53:14 -0400 |
| commit | 6dd4a077c0fd2bcd964dd6195b80fef66b5e4c3b (patch) | |
| tree | 22608e3080f3571df2e3f2331dd0ebc147fb67ae /common.gypi | |
| parent | 1a1fe53e3dbd0042807b75caac94dcae0abe4dc1 (diff) | |
| download | android-node-v8-6dd4a077c0fd2bcd964dd6195b80fef66b5e4c3b.tar.gz android-node-v8-6dd4a077c0fd2bcd964dd6195b80fef66b5e4c3b.tar.bz2 android-node-v8-6dd4a077c0fd2bcd964dd6195b80fef66b5e4c3b.zip | |
build: reduce chance of unneeded rebuild
Run `node_js2c` and `mkssldef` as actions and not as targets makes sure
they are run only once, just before processing the rest of `node_lib`.
This helps `make` based dependency change detection be more accurate.
Add comments with tagrget names for readability.
Use `process_outputs_as_sources` for automatic inclution of outputs.
PR-URL: https://github.com/nodejs/node/pull/23156
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'common.gypi')
| -rw-r--r-- | common.gypi | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/common.gypi b/common.gypi index 46711ac76d..af06295a85 100644 --- a/common.gypi +++ b/common.gypi @@ -22,6 +22,8 @@ 'node_tag%': '', 'uv_library%': 'static_library', + 'clang%': 0, + 'openssl_fips%': '', # Default to -O0 for debug builds. @@ -91,8 +93,6 @@ }], ['OS=="mac"', { 'clang%': 1, - }, { - 'clang%': 0, }], ], }, |