diff options
| author | Refael Ackermann <refack@gmail.com> | 2018-09-03 22:00:09 -0400 |
|---|---|---|
| committer | Refael Ackermann <refack@gmail.com> | 2018-09-11 19:58:44 -0400 |
| commit | 54e76fb873027cc6089bf8d7359d188d3687909e (patch) | |
| tree | b5989f9ab6879937a667ab988ddeb44236bbe75d /common.gypi | |
| parent | 7a10b86ab705c2e8181541d0bea2ca25a15e8226 (diff) | |
| download | android-node-v8-54e76fb873027cc6089bf8d7359d188d3687909e.tar.gz android-node-v8-54e76fb873027cc6089bf8d7359d188d3687909e.tar.bz2 android-node-v8-54e76fb873027cc6089bf8d7359d188d3687909e.zip | |
build,win: exclude warning 4244 only for deps
* also unify warning exclusion directive
PR-URL: https://github.com/nodejs/node/pull/22698
Reviewed-By: João Reis <reis@janeasystems.com>
Diffstat (limited to 'common.gypi')
| -rw-r--r-- | common.gypi | 27 |
1 files changed, 14 insertions, 13 deletions
diff --git a/common.gypi b/common.gypi index 273c6b241a..cba83cc8cf 100644 --- a/common.gypi +++ b/common.gypi @@ -274,18 +274,6 @@ 'BufferSecurityCheck': 'true', 'ExceptionHandling': 0, # /EHsc 'SuppressStartupBanner': 'true', - # Disable warnings: - # - "C4251: class needs to have dll-interface" - # - "C4275: non-DLL-interface used as base for DLL-interface" - # Over 10k of these warnings are generated when compiling node, - # originating from v8.h. Most of them are false positives. - # See also: https://github.com/nodejs/node/pull/15570 - # TODO: re-enable when Visual Studio fixes these upstream. - # - # - "C4267: conversion from 'size_t' to 'int'" - # Many any originate from our dependencies, and their sheer number - # drowns out other, more legitimate warnings. - 'DisableSpecificWarnings': ['4251', '4275', '4267'], 'WarnAsError': 'false', }, 'VCLinkerTool': { @@ -316,7 +304,20 @@ 'SuppressStartupBanner': 'true', }, }, - 'msvs_disabled_warnings': [4351, 4355, 4800], + # Disable warnings: + # - "C4251: class needs to have dll-interface" + # - "C4275: non-DLL-interface used as base for DLL-interface" + # Over 10k of these warnings are generated when compiling node, + # originating from v8.h. Most of them are false positives. + # See also: https://github.com/nodejs/node/pull/15570 + # TODO: re-enable when Visual Studio fixes these upstream. + # + # - "C4267: conversion from 'size_t' to 'int'" + # Many any originate from our dependencies, and their sheer number + # drowns out other, more legitimate warnings. + # - "C4244: conversion from 'type1' to 'type2', possible loss of data" + # Ususaly safe. Disable for `dep`, enable for `src` + 'msvs_disabled_warnings': [4351, 4355, 4800, 4251, 4275, 4244, 4267], 'conditions': [ ['asan == 1 and OS != "mac"', { 'cflags+': [ |