diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2018-11-09 11:55:37 +0100 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-11-12 07:29:21 +0100 |
| commit | 4684de6423ee48635c6d4fc3e990af38618aaf0f (patch) | |
| tree | 62fe0297c2432d94202033be001b8a845f5fd937 /common.gypi | |
| parent | a8847aa5e009e4c487a0d895cfeaea0080e33a29 (diff) | |
| download | android-node-v8-4684de6423ee48635c6d4fc3e990af38618aaf0f.tar.gz android-node-v8-4684de6423ee48635c6d4fc3e990af38618aaf0f.tar.bz2 android-node-v8-4684de6423ee48635c6d4fc3e990af38618aaf0f.zip | |
build: disable openssl asm on arm64 for now
There is reason to believe the generated assembly isn't working
correctly so let's disable it for now pending further investigation.
PR-URL: https://github.com/nodejs/node/pull/24270
Refs: https://github.com/nodejs/node/issues/23913
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'common.gypi')
| -rw-r--r-- | common.gypi | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/common.gypi b/common.gypi index f92791f946..a1ecdc6d6f 100644 --- a/common.gypi +++ b/common.gypi @@ -27,7 +27,6 @@ 'clang%': 0, - 'openssl_no_asm%': 0, 'openssl_fips%': '', # Reset this number to 0 on major V8 upgrades. @@ -52,6 +51,12 @@ 'icu_use_data_file_flag%': 0, 'conditions': [ + ['target_arch=="arm64"', { + # Disabled pending https://github.com/nodejs/node/issues/23913. + 'openssl_no_asm%': 1, + }, { + 'openssl_no_asm%': 0, + }], ['GENERATOR=="ninja"', { 'obj_dir': '<(PRODUCT_DIR)/obj', 'conditions': [ |