diff options
author | Ruben Bridgewater <ruben@bridgewater.de> | 2018-12-03 17:15:45 +0100 |
---|---|---|
committer | Ruben Bridgewater <ruben@bridgewater.de> | 2018-12-10 17:07:18 +0100 |
commit | 1f85ea979ccef3c52ec4ca3263306e527b625498 (patch) | |
tree | f318be6ee905b1a04d1d2db859720c4b33b22aa8 /benchmark | |
parent | cc8250fab86486632fdeb63892be735d7628cd13 (diff) | |
download | android-node-v8-1f85ea979ccef3c52ec4ca3263306e527b625498.tar.gz android-node-v8-1f85ea979ccef3c52ec4ca3263306e527b625498.tar.bz2 android-node-v8-1f85ea979ccef3c52ec4ca3263306e527b625498.zip |
tools: capitalize sentences
This adds the `capitalized-comments` eslint rule to verify that
actual sentences use capital letters as starting letters. It ignores
special words and all lines below 62 characters.
PR-URL: https://github.com/nodejs/node/pull/24808
Reviewed-By: Sam Ruby <rubys@intertwingly.net>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Diffstat (limited to 'benchmark')
-rw-r--r-- | benchmark/_cli.js | 2 | ||||
-rw-r--r-- | benchmark/child_process/child-process-exec-stdout.js | 2 | ||||
-rw-r--r-- | benchmark/common.js | 4 | ||||
-rw-r--r-- | benchmark/crypto/cipher-stream.js | 2 | ||||
-rw-r--r-- | benchmark/dgram/array-vs-concat.js | 2 | ||||
-rw-r--r-- | benchmark/dgram/offset-length.js | 2 | ||||
-rw-r--r-- | benchmark/napi/function_call/index.js | 2 | ||||
-rw-r--r-- | benchmark/net/net-wrap-js-stream-passthrough.js | 2 |
8 files changed, 9 insertions, 9 deletions
diff --git a/benchmark/_cli.js b/benchmark/_cli.js index 4d92b05b1b..0c39c0b193 100644 --- a/benchmark/_cli.js +++ b/benchmark/_cli.js @@ -49,7 +49,7 @@ function CLI(usage, settings) { this.optional[currentOptional] = true; mode = 'both'; } else { - // expect the next value to be option related (either -- or the value) + // Expect the next value to be option related (either -- or the value) mode = 'option'; } } else if (mode === 'option') { diff --git a/benchmark/child_process/child-process-exec-stdout.js b/benchmark/child_process/child-process-exec-stdout.js index 88c02533f6..a1dc4aa04c 100644 --- a/benchmark/child_process/child-process-exec-stdout.js +++ b/benchmark/child_process/child-process-exec-stdout.js @@ -31,7 +31,7 @@ function childProcessExecStdout({ dur, len }) { try { execSync(`taskkill /f /t /pid ${child.pid}`); } catch { - // this is a best effort kill. stderr is piped to parent for tracing. + // This is a best effort kill. stderr is piped to parent for tracing. } } else { child.kill(); diff --git a/benchmark/common.js b/benchmark/common.js index d5e0494c16..521a145997 100644 --- a/benchmark/common.js +++ b/benchmark/common.js @@ -146,7 +146,7 @@ Benchmark.prototype._run = function() { (function recursive(queueIndex) { const config = self.queue[queueIndex]; - // set NODE_RUN_BENCHMARK_FN to indicate that the child shouldn't construct + // Set NODE_RUN_BENCHMARK_FN to indicate that the child shouldn't construct // a configuration queue, but just execute the benchmark function. const childEnv = Object.assign({}, process.env); childEnv.NODE_RUN_BENCHMARK_FN = ''; @@ -187,7 +187,7 @@ Benchmark.prototype.start = function() { }; Benchmark.prototype.end = function(operations) { - // get elapsed time now and do error checking later for accuracy. + // Get elapsed time now and do error checking later for accuracy. const elapsed = process.hrtime(this._time); if (!this._started) { diff --git a/benchmark/crypto/cipher-stream.js b/benchmark/crypto/cipher-stream.js index 9f986dfb36..c9989d32dc 100644 --- a/benchmark/crypto/cipher-stream.js +++ b/benchmark/crypto/cipher-stream.js @@ -58,7 +58,7 @@ function main({ api, cipher, type, len, writes }) { const fn = api === 'stream' ? streamWrite : legacyWrite; - // write data as fast as possible to alice, and have bob decrypt. + // Write data as fast as possible to alice, and have bob decrypt. // use old API for comparison to v0.8 bench.start(); fn(alice_cipher, bob_cipher, message, encoding, writes); diff --git a/benchmark/dgram/array-vs-concat.js b/benchmark/dgram/array-vs-concat.js index a7843a9c7f..c73c953858 100644 --- a/benchmark/dgram/array-vs-concat.js +++ b/benchmark/dgram/array-vs-concat.js @@ -1,4 +1,4 @@ -// test UDP send throughput with the multi buffer API against Buffer.concat +// Test UDP send throughput with the multi buffer API against Buffer.concat 'use strict'; const common = require('../common.js'); diff --git a/benchmark/dgram/offset-length.js b/benchmark/dgram/offset-length.js index 8a2df9ac67..7c78765cee 100644 --- a/benchmark/dgram/offset-length.js +++ b/benchmark/dgram/offset-length.js @@ -1,4 +1,4 @@ -// test UDP send/recv throughput with the "old" offset/length API +// Test UDP send/recv throughput with the "old" offset/length API 'use strict'; const common = require('../common.js'); diff --git a/benchmark/napi/function_call/index.js b/benchmark/napi/function_call/index.js index 59063e500f..e7d9fe46e5 100644 --- a/benchmark/napi/function_call/index.js +++ b/benchmark/napi/function_call/index.js @@ -7,7 +7,7 @@ const assert = require('assert'); const common = require('../../common.js'); -// this fails when we try to open with a different version of node, +// This fails when we try to open with a different version of node, // which is quite common for benchmarks. so in that case, just // abort quietly. diff --git a/benchmark/net/net-wrap-js-stream-passthrough.js b/benchmark/net/net-wrap-js-stream-passthrough.js index c4d11fa56c..0e76281b25 100644 --- a/benchmark/net/net-wrap-js-stream-passthrough.js +++ b/benchmark/net/net-wrap-js-stream-passthrough.js @@ -1,4 +1,4 @@ -// test the speed of .pipe() with JSStream wrapping for PassThrough streams +// Test the speed of .pipe() with JSStream wrapping for PassThrough streams 'use strict'; const common = require('../common.js'); |