summaryrefslogtreecommitdiff
path: root/CONTRIBUTING.md
diff options
context:
space:
mode:
authorJonathan Boarman <jb@jonathan.net>2016-12-04 06:43:43 -0600
committerJames M Snell <jasnell@gmail.com>2017-01-10 10:11:24 -0800
commited9b6c1264a07084e44f1d269bfe82e0f1b37c74 (patch)
treeca7a4dc18373de94c5fa6efaa58f6ae8de5fcd10 /CONTRIBUTING.md
parent762a303e1fdec6a3d13c0f3fc5dd2ceb33d84e9a (diff)
downloadandroid-node-v8-ed9b6c1264a07084e44f1d269bfe82e0f1b37c74.tar.gz
android-node-v8-ed9b6c1264a07084e44f1d269bfe82e0f1b37c74.tar.bz2
android-node-v8-ed9b6c1264a07084e44f1d269bfe82e0f1b37c74.zip
doc: correct vcbuild options for windows testing
Corrected parameter for running tests on Windows. Without the corrected parameters, Windows users encounter an error about failing to sign the build, "Failed to sign exe", which can be discouraging to new Windows community members. PR-URL: https://github.com/nodejs/node/pull/10686 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Diffstat (limited to 'CONTRIBUTING.md')
-rw-r--r--CONTRIBUTING.md6
1 files changed, 3 insertions, 3 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index c60eeb1c6e..736a9542c4 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -170,7 +170,7 @@ $ ./configure && make -j4 test
Windows:
```text
-> vcbuild test
+ .\vcbuild nosign test
```
(See the [BUILDING.md](./BUILDING.md) for more details.)
@@ -178,11 +178,11 @@ Windows:
Make sure the linter is happy and that all tests pass. Please, do not submit
patches that fail either check.
-Running `make test`/`vcbuild test` will run the linter as well unless one or
+Running `make test`/`.\vcbuild nosign test` will run the linter as well unless one or
more tests fail.
If you want to run the linter without running tests, use
-`make lint`/`vcbuild jslint`.
+`make lint`/`.\vcbuild nosign jslint`.
If you are updating tests and just want to run a single test to check it, you
can use this syntax to run it exactly as the test harness would: