diff options
| author | Rich Trott <rtrott@gmail.com> | 2017-12-31 21:18:44 -0800 |
|---|---|---|
| committer | Anatoli Papirovski <apapirovski@mac.com> | 2018-01-03 13:47:58 -0500 |
| commit | e6a401e0ae01952294f867fbbd715937f8557718 (patch) | |
| tree | 82f88d6cab126f2d09e0bf695a62050fb7880d05 /CONTRIBUTING.md | |
| parent | 5bda05548bcfd473b3b112fe388ae64f862af86d (diff) | |
| download | android-node-v8-e6a401e0ae01952294f867fbbd715937f8557718.tar.gz android-node-v8-e6a401e0ae01952294f867fbbd715937f8557718.tar.bz2 android-node-v8-e6a401e0ae01952294f867fbbd715937f8557718.zip | |
doc: improve PR-review paragraph in CONTRIBUTING.md
* Remove redundant "blocking it or stopping it" as blocking and stopping
are the same thing in this case.
* Make another sentence less wordy. Fix incorrect verb conjugation.
Break into two clear sentences.
PR-URL: https://github.com/nodejs/node/pull/17931
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 1dbaadf685..b1cc67ada5 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -602,12 +602,11 @@ your name on it. Congratulations and thanks for your contribution! All Node.js contributors who choose to review and provide feedback on Pull Requests have a responsibility to both the project and the individual making the contribution. Reviews and feedback must be helpful, insightful, and geared -towards improving the contribution as opposed to simply blocking it or -stopping it. If there are reasons why you feel the PR should not land, explain -what those are. Do not expect to be able to block a Pull Request from advancing -simply because you say "No" without giving an explanation. It is also important -to be open to having your mind changed, and to being open to working with the -contributor to make the Pull Request better. +towards improving the contribution as opposed to simply blocking it. If there +are reasons why you feel the PR should not land, explain what those are. Do not +expect to be able to block a Pull Request from advancing simply because you say +"No" without giving an explanation. Be open to having your mind changed. Be open +to working with the contributor to make the Pull Request better. Reviews that are dismissive or disrespectful of the contributor or any other reviewers are strictly counter to the [Code of Conduct][]. |