diff options
| author | Matheus Marchini <matheusdot@gmail.com> | 2017-11-03 23:10:10 -0200 |
|---|---|---|
| committer | Joyee Cheung <joyeec9h3@gmail.com> | 2018-01-18 21:27:00 +0800 |
| commit | c134ff24f44ca523566bd38aa2d49f0dce7401aa (patch) | |
| tree | b79e43607f05a894cb856d6cb3c6969fcf3242a9 /BUILDING.md | |
| parent | 38ee25e2e205270c6ff258742aa34b442d9bc580 (diff) | |
| download | android-node-v8-c134ff24f44ca523566bd38aa2d49f0dce7401aa.tar.gz android-node-v8-c134ff24f44ca523566bd38aa2d49f0dce7401aa.tar.bz2 android-node-v8-c134ff24f44ca523566bd38aa2d49f0dce7401aa.zip | |
doc: warn users about non-ASCII paths on build
The build breaks if there's a non-ASCII character on
the path to the building directory.
PR-URL: https://github.com/nodejs/node/pull/16735
Refs: https://github.com/nodejs/node/issues/16278
Refs: https://github.com/nodejs/node/issues/14336
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'BUILDING.md')
| -rw-r--r-- | BUILDING.md | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/BUILDING.md b/BUILDING.md index 296296e558..10e9a910be 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -232,7 +232,8 @@ Prerequisites: * **Optional** (to build the MSI): the [WiX Toolset v3.11](http://wixtoolset.org/releases/) and the [Wix Toolset Visual Studio 2017 Extension](https://marketplace.visualstudio.com/items?itemName=RobMensching.WixToolsetVisualStudio2017Extension). -If the path to your build directory contains a space, the build will likely fail. +If the path to your build directory contains a space or a non-ASCII character, the +build will likely fail. ```console > .\vcbuild |