diff options
| author | Rich Trott <rtrott@gmail.com> | 2016-05-29 22:32:12 -0700 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2016-06-01 19:46:10 -0700 |
| commit | e350deb1e342c07a7fd06c208811ef832aba5c3d (patch) | |
| tree | e3638a96a6277c7d4da7cbba708ed80f560eab62 /.github | |
| parent | 85da963ddabf12ebb90dc8f28e88546c96582409 (diff) | |
| download | android-node-v8-e350deb1e342c07a7fd06c208811ef832aba5c3d.tar.gz android-node-v8-e350deb1e342c07a7fd06c208811ef832aba5c3d.tar.bz2 android-node-v8-e350deb1e342c07a7fd06c208811ef832aba5c3d.zip | |
doc: edit pull request template
Move checklist instructions closer to the checklist. Trim unnecessary
words.
PR-URL: https://github.com/nodejs/node/pull/7058
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Diffstat (limited to '.github')
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index cce9351dc1..bc5ba6fafc 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,9 +1,7 @@ <!-- -Thank you for your pull request. Please review below requirements and walk -through the checklist. You can 'tick' a box by using the letter "x": [x]. +Thank you for your pull request. Please review below requirements. -Run the test suite with: `make -j4 test` on UNIX or `vcbuild test nosign` on -Windows. +Run tests with `make -j4 test` on UNIX or `vcbuild test nosign` on Windows. If this aims to fix a regression or you’re adding a feature, make sure you also write a test. If possible, include a benchmark that quantifies your changes. @@ -13,7 +11,7 @@ https://github.com/nodejs/node/blob/master/CONTRIBUTING.md --> ##### Checklist -<!-- remove lines that do not apply to you --> +<!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> - [ ] tests and code linting passes - [ ] a test and/or benchmark is included |