diff options
| author | Rich Trott <rtrott@gmail.com> | 2018-03-03 22:10:19 -0800 |
|---|---|---|
| committer | Anatoli Papirovski <apapirovski@mac.com> | 2018-03-06 09:33:16 +0100 |
| commit | c72e540cde6695176bd7d218a1ed6584e2a0b9c7 (patch) | |
| tree | 4adc952d0cc1395b4d5136ad53837decfa624334 /.github | |
| parent | fe8d4a7ea7eeef21b25df4c5059a9e4e15b004c9 (diff) | |
| download | android-node-v8-c72e540cde6695176bd7d218a1ed6584e2a0b9c7.tar.gz android-node-v8-c72e540cde6695176bd7d218a1ed6584e2a0b9c7.tar.bz2 android-node-v8-c72e540cde6695176bd7d218a1ed6584e2a0b9c7.zip | |
doc: remove subsystem from pull request template
Remove request that user provide a list of subsystems in the pull
request template.
* We already ask them to put the subsystems in the first line of the
commit message.
* The subsystem is usually easy to determine.
* We have a bot that applies subsystem labels on new PRs and it seems to
do a rather good job. Tools over rules. Let the bot do it.
* The fewer unnecessary things we ask for in the template, the lower the
barrier to entry.
* Anecdotal, but I have never found it useful to have the person
submitting the PR list out subsystems in the pull request post.
PR-URL: https://github.com/nodejs/node/pull/19125
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Diffstat (limited to '.github')
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 63e76a27fa..f85c224898 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -14,6 +14,3 @@ Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md - [ ] tests and/or benchmarks are included - [ ] documentation is changed or added - [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines) - -##### Affected core subsystem(s) -<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). --> |