diff options
| author | Joe Doyle <joe@joedoyle.us> | 2016-12-06 12:52:59 -0800 |
|---|---|---|
| committer | João Reis <reis@janeasystems.com> | 2016-12-18 01:19:34 +0000 |
| commit | 92ed1ab45059e3c822dc661a4917bb5232707315 (patch) | |
| tree | 381ae912bc1a19909d790f643b3e30d952d1ed05 /.github | |
| parent | f7f662cad582cedec85236a94d753be08e3cd446 (diff) | |
| download | android-node-v8-92ed1ab45059e3c822dc661a4917bb5232707315.tar.gz android-node-v8-92ed1ab45059e3c822dc661a4917bb5232707315.tar.bz2 android-node-v8-92ed1ab45059e3c822dc661a4917bb5232707315.zip | |
build: change nosign flag to sign and flips logic
Makes the default build on Windows not try to sign the node.exe
binary after a build. Instead the 'sign' flag now indicates that the
binary should be signed. The 'nosign' flag is left as a noop.
Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
PR-URL: https://github.com/nodejs/node/pull/10156
Diffstat (limited to '.github')
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 7b00480120..0cc8ca8d5e 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -9,7 +9,7 @@ Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md ##### Checklist <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> -- [ ] `make -j4 test` (UNIX), or `vcbuild test nosign` (Windows) passes +- [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes - [ ] tests and/or benchmarks are included - [ ] documentation is changed or added - [ ] commit message follows commit guidelines |