diff options
| author | Rich Trott <rtrott@gmail.com> | 2016-06-04 14:13:49 -0700 |
|---|---|---|
| committer | Julian Duque <julianduquej@gmail.com> | 2016-06-06 22:55:19 -0400 |
| commit | 015574402417bc3f2d285407a7816a84a89a7830 (patch) | |
| tree | acd35307d34ad7eba01ad80c87c94ca96cb33c31 /.github | |
| parent | 101bda1b40d135f6f6bf2c71fb41f250c53acd95 (diff) | |
| download | android-node-v8-015574402417bc3f2d285407a7816a84a89a7830.tar.gz android-node-v8-015574402417bc3f2d285407a7816a84a89a7830.tar.bz2 android-node-v8-015574402417bc3f2d285407a7816a84a89a7830.zip | |
doc: consolidate test/lint text in GH PR template
PR-URL: https://github.com/nodejs/node/pull/7155
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to '.github')
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index bc5ba6fafc..04ced4834f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,8 +1,6 @@ <!-- Thank you for your pull request. Please review below requirements. -Run tests with `make -j4 test` on UNIX or `vcbuild test nosign` on Windows. - If this aims to fix a regression or you’re adding a feature, make sure you also write a test. If possible, include a benchmark that quantifies your changes. @@ -13,7 +11,7 @@ https://github.com/nodejs/node/blob/master/CONTRIBUTING.md ##### Checklist <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> -- [ ] tests and code linting passes +- [ ] `make -j4 test` (UNIX) or `vcbuild test nosign` (Windows) passes - [ ] a test and/or benchmark is included - [ ] documentation is changed or added - [ ] the commit message follows commit guidelines |