diff options
| author | Rich Trott <rtrott@gmail.com> | 2017-04-04 10:26:34 -0700 |
|---|---|---|
| committer | James M Snell <jasnell@gmail.com> | 2017-04-05 18:41:38 -0700 |
| commit | 01460776fe3339b905fcf6035e710d44599a0211 (patch) | |
| tree | 0dc886338916c5d6d45b77418b9a6e4a9ccd928d /.github | |
| parent | 51587b22029a53b32122b5d577defb6a7577ea5f (diff) | |
| download | android-node-v8-01460776fe3339b905fcf6035e710d44599a0211.tar.gz android-node-v8-01460776fe3339b905fcf6035e710d44599a0211.tar.bz2 android-node-v8-01460776fe3339b905fcf6035e710d44599a0211.zip | |
doc: update pull request template URL layout
Putting the link for the commit guideline at the bottom of the pull
request template makes it a bit confusing when opening a pull request as
the markdown does not render. Not everyone is familiar with the syntax
used there and it is easy to mess it up (for example, by not leaving a
blank line above it). It is more natural and useful if the URL is
included inline.
PR-URL: https://github.com/nodejs/node/pull/12216
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to '.github')
| -rw-r--r-- | .github/PULL_REQUEST_TEMPLATE.md | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 4b37b83250..ebffbd1fc8 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -13,9 +13,7 @@ Contributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md - [ ] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes - [ ] tests and/or benchmarks are included - [ ] documentation is changed or added -- [ ] commit message follows [commit guidelines][] +- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines) ##### Affected core subsystem(s) <!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). --> - -[commit guidelines]: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md#commit-guidelines |